Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for UCA and security invariant test failures on repertoire PRs #851

Merged
merged 24 commits into from
Jun 6, 2024

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jun 5, 2024

https://github.com/unicode-org/unicodetools/blob/main/docs/pipeline.md says

The Check UCA data CI check might fail; many character additions need separate handling there, but that is out of scope for the PAG work of preparing data-for-new. This will get resolved later.

But now the security check also systematically fails; being an invariant test, it also brings up error messages in the diff. This can easily lead to missing real invariant check failures—which may point to potential issues with encoding proposals—, as we start expecting proposal PRs to be red.

In order to address that issue, this PR silences the UCA and security invariant failures on PR runs for changes to the répertoire (the build at main will still go red if we merge UCA or security breakages, which we may want to do before the start of the β phase). PRs that do not affect the répertoire will also get the full CI results.

When silenced, the security invariant test failures still show up in the diff, but as notices (in grey) rather than errors (in red).

See it in action:

  1. in 9bd67946d9ec4798ce5b02697eaab46608c8ba27, the only two failing CI checks are due to UCD invariant check failures, and the security invariant test failure is reported as a notice rather than an error;
  2. in 2c1c296ed470362cc2cc13ef714cb799d521113e, there are no failing CI checks (all is green), and the security invariant test failure is reported as a notice rather than an error;
  3. in d8f557dcb497f0141223a7ebada2b3a088d42426, there are no répertoire changes, so the CI checks run normally: both the UCA and the security invariants are broken.

@eggrobin eggrobin changed the title Allow for UCA and security failures on repertoire PRs Allow for security invariant test failures on repertoire PRs Jun 5, 2024
@eggrobin eggrobin changed the title Allow for security invariant test failures on repertoire PRs Allow for UCA and security invariant test failures on repertoire PRs Jun 5, 2024
@eggrobin eggrobin requested a review from markusicu June 5, 2024 23:04
@eggrobin eggrobin marked this pull request as ready for review June 5, 2024 23:04
@markusicu markusicu requested a review from echeran June 5, 2024 23:18
@markusicu markusicu requested a review from josh-hadley June 5, 2024 23:18
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks plausible...

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@eggrobin eggrobin merged commit 84c5be3 into unicode-org:main Jun 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants