-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for UCA and security invariant test failures on repertoire PRs #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
changed the title
Allow for UCA and security failures on repertoire PRs
Allow for security invariant test failures on repertoire PRs
Jun 5, 2024
eggrobin
changed the title
Allow for security invariant test failures on repertoire PRs
Allow for UCA and security invariant test failures on repertoire PRs
Jun 5, 2024
markusicu
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks plausible...
macchiati
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/unicode-org/unicodetools/blob/main/docs/pipeline.md says
But now the security check also systematically fails; being an invariant test, it also brings up error messages in the diff. This can easily lead to missing real invariant check failures—which may point to potential issues with encoding proposals—, as we start expecting proposal PRs to be red.
In order to address that issue, this PR silences the UCA and security invariant failures on PR runs for changes to the répertoire (the build at main will still go red if we merge UCA or security breakages, which we may want to do before the start of the β phase). PRs that do not affect the répertoire will also get the full CI results.
When silenced, the security invariant test failures still show up in the diff, but as notices (in grey) rather than errors (in red).
See it in action: